Silence leaf shadow count assert spam#1986
Merged
Merged
Conversation
AdamTadeusz
approved these changes
Jun 11, 2026
DESTROYGIRL
approved these changes
Jun 11, 2026
This reverts commit 84a63ed (Add dev excludes on shadowleaf limits)
Rainyan
force-pushed
the
silence-shadowleaf-spam
branch
from
b686d77 to
9ebe423
Compare
Member
Author
|
GitHub, push to master, make no mistakes. |
Contributor
|
please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Silence the assertion spam that would trigger for every frame on debug builds when
m_ShadowsInLeaf > 2000, tanking dev build performance.We previously had a clunky per-map check in place to try and silence the warning, but the map list wasn't comprehensive, and also completely hiding the issue wasn't too great either. So instead just assert once, until we can either fix the shadow counts or decide to bump the shadow count upper bound for the assertion.
Toolchain
Linked Issues